Skip to content

fix sql insert syntax#28698

Closed
updbqn wants to merge 1 commit intocloudflare:productionfrom
updbqn:patch-2
Closed

fix sql insert syntax#28698
updbqn wants to merge 1 commit intocloudflare:productionfrom
updbqn:patch-2

Conversation

@updbqn
Copy link
Copy Markdown
Contributor

@updbqn updbqn commented Mar 2, 2026

Summary

"foo@bar.com" is an identifier not a string.

→  insert into example_users values ("foo@bar.com");
Error: failed to execute SQL:
SQLite input error: no such column: foo@bar.com (at offset 34)

updated to single quotes.

@github-actions github-actions bot added product:workers Related to Workers product size/xs labels Mar 2, 2026
@elithrar
Copy link
Copy Markdown
Collaborator

elithrar commented Mar 2, 2026

/lilbonk review this.

ask-bonk[bot]
ask-bonk bot approved these changes Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct fix. In SQLite (used by Turso), double quotes identify column names, while single quotes denote string literals. The change from "foo@bar.com" to 'foo@bar.com' resolves the 'no such column' error.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 2, 2026

Review submitted: #28698 (review)

github run

@updbqn updbqn closed this by deleting the head repository Mar 2, 2026
@updbqn updbqn mentioned this pull request Mar 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ask-bonk ask-bonk[bot] ask-bonk[bot] approved these changes

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

@irvinebroque irvinebroque Awaiting requested review from irvinebroque irvinebroque is a code owner

@mikenomitch mikenomitch Awaiting requested review from mikenomitch mikenomitch is a code owner

@korinne korinne Awaiting requested review from korinne korinne is a code owner

@WalshyDev WalshyDev Awaiting requested review from WalshyDev WalshyDev is a code owner

@MattieTK MattieTK Awaiting requested review from MattieTK MattieTK is a code owner

Assignees

@MattieTK MattieTK

@irvinebroque irvinebroque

@mikenomitch mikenomitch

@GregBrimble GregBrimble

@WalshyDev WalshyDev

@korinne korinne

Labels

product:workers Related to Workers product size/xs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@updbqn @elithrar @MattieTK @irvinebroque @mikenomitch @GregBrimble @WalshyDev @korinne